This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(noRedeclare): allow merging namespace + variable #4772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
github-actions
bot
added
A-Linter
1 task
llllvvuu
force-pushed
the
test/failing_redeclare
branch
from
23e2511
to
6fdad59
Compare
llllvvuu
changed the title
Conaclos
suggested changes
Aug 19, 2023
crates/rome_js_analyze/tests/specs/suspicious/noRedeclare/valid-declaration-merging.ts
Show resolved
Hide resolved
I was not aware of the merging capability between a variable and an only-type namespace. |
|
Yes, TypeScript is very weird 😂 Concrete variable example added! CI failure should be fixed by #4766 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4771
Note:
tscdoesn't always allow merging namespaces and variables. Either way, checking this shouldn't fall under the linter - either it's a type error or it's a declaration merge, but it's never a shadow.