Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap timer functions in try/catch #275

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

romgrk
Copy link
Owner

@romgrk romgrk commented Mar 29, 2021

This is another patch on our event loop issues, it should be removed when we're handling things more cleanly.

Link: #273

Edit: for the record, this is required because otherwise if an error occurs within a timer callback, nodejs crashes with an Error: async hook stack has become corrupted.

@romgrk romgrk merged commit 3c8cff9 into master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant