-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitstatus_start_impl: declare os variable. #92
Conversation
It's declared on the next line. What am I missing? Could you explain how to reproduce this error? Start by typing |
When the os variable isn't declared I get the following error on initialization: > gitstatus_start_impl:28: os: parameter not set The error is raised by the following line: [[ -n $os ]] || { os="$(uname -s)" && [[ -n $os ]] }
So it is. I don't know zsh very well but there seems to be some condition where declaring and defining multiple variables on one line doesn't work. |
Could you answer this question? |
Sorry, I can't reproduce in that way and I'm now pretty sure it's an issue with an overly aggressive patch in my distribution. |
Merged. I believe the PR is a no-op but if it helps you then why not. |
This is a followup to NixOS#76744. The patch is still too aggressive because it captures additional local variables declared in the same line. It should stop when it hits whitespace. See romkatv/gitstatus#92.
Well thanks for asking the right questions which pushed me toward the true problem. See NixOS/nixpkgs#77580. |
This is a followup to NixOS#76744. The patch is still too aggressive because it captures additional local variables declared in the same line. It should stop when it hits whitespace. See romkatv/gitstatus#92. (cherry picked from commit be4efc8)
gitstatus_start_impl: declare os variable.
When the os variable isn't declared I get the following error on
initialization:
The error is raised by the following line: