Add trunk.io checks #868

gantoine · 2024-05-22T13:32:36Z

No description provided.

github-actions · 2024-05-22T13:34:28Z

Test Results

73 tests ±0 73 ✅ ±0 24s ⏱️ +2s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit eb27780. ± Comparison against base commit 577fe9a.

♻️ This comment has been updated with latest results.

gantoine · 2024-06-03T02:09:43Z

backend/endpoints/sockets/scan.py

+
+    if not metadata_sources:
+        metadata_sources = ["igdb", "moby"]
+


gantoine · 2024-06-03T02:11:16Z

backend/handler/database/roms_handler.py

-                    Rom.file_name.ilike(f"%{search_term}%"),
-                    Rom.name.ilike(f"%{search_term}%"),
+                    Rom.file_name.ilike(f"%{search_term}%"),  # type: ignore[attr-defined]
+                    Rom.name.ilike(f"%{search_term}%"),  # type: ignore[attr-defined]


mypy doesn't play nice with sqlalchemy

gantoine · 2024-06-03T02:12:52Z

backend/handler/filesystem/base_handler.py

-                ]
+                for name in excluded_names:
+                    if file_name == name or fnmatch.fnmatch(file_name, name):
+                        excluded_files.append(file_name)


gantoine · 2024-06-03T02:14:40Z

backend/handler/metadata/igdb_handler.py

+                    name=s["name"],
+                    cover_url=pydash.get(s, "cover.url", ""),
+                    type="similar",
+                )


gantoine · 2024-06-03T02:15:52Z

backend/handler/scan_handler.py

 ) -> Rom:
+    if not metadata_sources:
+        metadata_sources = ["igdb", "moby"]
+


gantoine · 2024-06-03T02:17:07Z

backend/models/rom.py

-                            and_(Rom.igdb_id == self.igdb_id, Rom.igdb_id != None),  # noqa
-                            and_(Rom.moby_id == self.moby_id, Rom.moby_id != None),  # noqa
+                            and_(Rom.igdb_id == self.igdb_id, Rom.igdb_id is not None),
+                            and_(Rom.moby_id == self.moby_id, Rom.moby_id is not None),


gantoine · 2024-06-03T02:29:49Z

frontend/src/components/Details/ActionBar.vue

-        <template v-slot:activator="{ props }">
-          <div v-bind="props">
+        <template #activator="{ props: tooltipProps }">
+          <div v-bind="tooltipProps">


gantoine · 2024-06-03T02:30:01Z

frontend/src/components/Details/ActionBar.vue

          <v-btn
            :disabled="!auth.scopes.includes('roms.write')"
-            v-bind="props"
+            v-bind="menuProps"


gantoine · 2024-06-03T02:33:29Z

frontend/src/components/Details/Info/GameInfo.vue

@@ -25,7 +41,7 @@ const galleryFilter = storeGalleryFilter();
    <v-divider class="mx-2 my-4" />
    <v-row no-gutters>
      <v-col class="text-caption">
-        <p v-html="rom.summary"></p>
+        <p v-text="rom.summary" />


gantoine · 2024-06-03T02:35:58Z

frontend/src/components/Details/Saves.vue

@@ -8,14 +8,15 @@ import type { Emitter } from "mitt";
 import { inject, ref } from "vue";

 const props = defineProps<{ rom: DetailedRom }>();
+const romRef = ref<DetailedRom>(props.rom);


gantoine · 2024-06-03T02:36:20Z

frontend/src/components/Details/SourceTable.vue

+          variant="outlined"
+          class="text-romm-accent-1"
+          label
+          @click.stop


gantoine · 2024-06-03T02:36:34Z

frontend/src/components/Details/States.vue

@@ -10,14 +10,15 @@ import storeRoms, { type DetailedRom } from "@/stores/roms";
 import type { StateSchema } from "@/__generated__";

 const props = defineProps<{ rom: DetailedRom }>();
+const romRef = ref<DetailedRom>(props.rom);


gantoine · 2024-06-03T02:59:04Z

frontend/src/components/Dialog/Rom/MatchRom/SelectSource.vue

+  url_cover: string | undefined;
+  name: string;
+  rom: SearchRomSchema;
+};


gantoine · 2024-06-03T03:00:01Z

frontend/src/components/Dialog/Rom/SearchRom.vue

              >
-                <v-hover v-slot="{ isHovering, props }" open-delay="800">
+                <v-hover
+                  v-slot="{ isHovering: isChildHovering, props: hoverProps }"


gantoine · 2024-06-03T03:02:35Z

frontend/src/components/Dialog/User/EditUser.vue

-  if (file) {
-    reader.readAsDataURL(file);
+  if (input.files[0]) {
+    reader.readAsDataURL(input.files[0]);


gantoine · 2024-06-03T03:10:20Z

frontend/src/components/Game/Card/Base.vue

@@ -25,18 +25,18 @@ function selectRom(event: MouseEvent) {
 </script>

 <template>
-  <v-hover v-slot="{ isHovering, props }">
+  <v-hover v-slot="{ isHovering, props: hoverProps }">


gantoine · 2024-06-03T03:20:16Z

frontend/src/views/Play/Player.vue

@@ -14,6 +14,7 @@ const props = defineProps<{
  bios: FirmwareSchema | null;
  core: string | null;
 }>();
+const romRef = ref<DetailedRom>(props.rom);


gantoine · 2024-06-03T03:21:14Z

frontend/vite.config.js

          changeOrigin: false,
          ws: true,
        },
        "/openapi.json": {
-          target: `http://localhost:${backendPort}`,
+          target: `http://127.0.0.1:${backendPort}`,


This PR contains the following updates: | Package | Update | Change | |---|---|---| | [rommapp/romm](https://togithub.com/rommapp/romm) | minor | `3.2.0` -> `3.3.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rommapp/romm (rommapp/romm)</summary> ### [`v3.3.0`](https://togithub.com/rommapp/romm/releases/tag/3.3.0) [Compare Source](https://togithub.com/rommapp/romm/compare/3.2.0...3.3.0) #### What's Changed - UI complete redesign by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#934 - Covers are now fetch in their 1080p version by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#934 - Now sibling roms can have different covers by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#934 - Screenshots are fetch in their big version by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#934 - Setup wizard added for new **RomM** installations by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#976 - Added collections by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#964 - Add favourites collection as special collection by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#977 - SteamGridDB integration. Roms and collections can be edited with a SteamGridDB cover by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#960 - Enhanced scan logs by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#965 - Select main sibling added for merged roms in gallery by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#963 - Allow users to edit their own profile by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#975 - Fixed firmware drawer permissions by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#956 - Added total filesize endpoint by [@adamantike](https://togithub.com/adamantike) in [rommapp/romm#969 - Improved Docker image size by [@adamantike](https://togithub.com/adamantike) in [rommapp/romm#947 - Install redis instead of building in Dockerfile by [@gantoine](https://togithub.com/gantoine) in [rommapp/romm#945 - Fix section links and improve grammar/spelling in README.md by [@TylerVigario](https://togithub.com/TylerVigario) in [rommapp/romm#914 - Add trunk.io checks by [@gantoine](https://togithub.com/gantoine) in [rommapp/romm#868 - Add parallel-n64 to cores by [@gantoine](https://togithub.com/gantoine) in [rommapp/romm#923 - Use core icon when showing version by [@gantoine](https://togithub.com/gantoine) in [rommapp/romm#922 - Add interactive table of contents by [@Nicmorris1820](https://togithub.com/Nicmorris1820) in [rommapp/romm#924 - Added linuxserver/mariadb as alternative by [@need4swede](https://togithub.com/need4swede) in [rommapp/romm#926 - Added large carousel on screnshot click by [@zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#932 - Resources structure migrated from `resources/{platform_slug}/{rom_name}` to `resources/roms/{platform_id}/{rom_id}`. - Disabled zip compression on streaming multi-file download to increase speed by [@adamantike](https://togithub.com/adamantike) in [rommapp/romm#983 - Prevent mass-purging of roms during scan if filesystem is not correctly mounted by [@gantoine](https://togithub.com/gantoine) in [rommapp/romm#987 - Fixed abort scan by [@gantoine](https://togithub.com/gantoine) in [rommapp/romm#1004 - Added support for any kind of image extension on custom covers by [@gantoine](https://togithub.com/gantoine) in [rommapp/romm#1002 - Fixes and improvements everywhere #### New Contributors - [@adamantike](https://togithub.com/adamantike) made their first contribution in [rommapp/romm#947 - [@TylerVigario](https://togithub.com/TylerVigario) made their first contribution in [rommapp/romm#914 - [@Nicmorris1820](https://togithub.com/Nicmorris1820) made their first contribution in [rommapp/romm#924 - [@need4swede](https://togithub.com/need4swede) made their first contribution in [rommapp/romm#926 - [@lepture](https://togithub.com/lepture) made their first contribution in [rommapp/romm#931 **Full Changelog**: rommapp/romm@3.2.0...3.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

gantoine added 6 commits May 21, 2024 10:15

trunk init

3302be9

run trunk format on all files

a7cf0d3

bunch of fixes for trunk

b2085f8

last bits of fixes

2a980a0

start fixing mypy issues

2b60402

finish mypy fixes

1840390

rommapp deleted a comment from trunk-io bot May 22, 2024

gantoine added 7 commits May 22, 2024 09:47

fix scan rom test

a62794b

disable heck pre push

92c0dd7

Merge branch 'master' into trunk-io

fcb34f9

run formatter

10479bd

run chech

ca1363a

Merge branch 'master' into trunk-io

b075e93

run trunk fixes

7635bbe

gantoine changed the title ~~Add Tunk Check~~ Add Trunk.io checks May 24, 2024

update trunk

98380ba

gantoine changed the title ~~Add Trunk.io checks~~ Add trunk.io checks May 24, 2024

gantoine force-pushed the trunk-io branch from ce588c4 to 06b0af9 Compare May 24, 2024 21:41

Empty commit

acb52f3

gantoine force-pushed the trunk-io branch from 06b0af9 to acb52f3 Compare May 24, 2024 21:46

gantoine and others added 9 commits May 24, 2024 17:50

add task to run in CI

8476068

Merge branch 'master' into trunk-io

9b62641

run truck fixes

c4ef4d9

Merge branch 'master' into trunk-io

05a4c42

add wokring eslint

4a712a6

fix most eslint errors

7f8f8e6

fix final eslint errors

6652ac8

run generator

dbf8636

Merge branch 'master' into trunk-io

eda8f5b

gantoine added 3 commits June 2, 2024 14:08

more fixes

a401f3c

playing around with trunk

f6c7aa4

fuck it working eslint

c2fb556

gantoine marked this pull request as ready for review June 2, 2024 23:32

fix generating oepnapi types

8990559