Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Remove mentions to unneeded Poetry fork #953

Merged

Conversation

adamantike
Copy link

Poetry 1.8.0 already includes support for package-mode = false, so there's no need to install a Poetry fork anymore.

Poetry 1.8.0 already includes support for `package-mode = false`, so
there's no need to install a Poetry fork anymore.
@adamantike adamantike force-pushed the misc/remove-mentions-to-poetry-fork branch from b6e5763 to 3d4a66c Compare June 24, 2024 10:38
@adamantike adamantike changed the title misc: Remove mentions to unneeded Poetry mention misc: Remove mentions to unneeded Poetry fork Jun 25, 2024
Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zurdi15 fyi this will require us to update our dev envs

@zurdi15
Copy link
Member

zurdi15 commented Jun 25, 2024

@zurdi15 fyi this will require us to update our dev envs

correct! already did today, nice to finally have the non-package mode in the stable release

@gantoine gantoine merged commit 4cb870b into rommapp:master Jun 25, 2024
3 checks passed
@gantoine
Copy link
Member

thanks for this one @adamantike!

@adamantike adamantike deleted the misc/remove-mentions-to-poetry-fork branch June 25, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants