Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start behavior #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bastianwegge
Copy link
Contributor

This PR fixes 2 issues I had when trying to start templier in my project (https://github.com/bastianwegge/gofiber-templ-bench).

  1. the PathProxyEvents = "/_templier/events" didn't work for me, since it holds unicode
  2. the server was always trying to start with TLS, but I wanted http, so I changed the check for TLS to make more sense

@coveralls
Copy link

coveralls commented Aug 18, 2024

Pull Request Test Coverage Report for Build 10458972888

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 0 1 0.0%
Totals Coverage Status
Change from base Build 10454627770: 0.0%
Covered Lines: 0
Relevant Lines: 443

💛 - Coveralls

@romshark
Copy link
Owner

As far as I remember, I used unicode URLs for the events WS endpoint in order to reduce the chances of naming conflicts with the application server, but I guess /_templier/events is relatively unlikely to colide.

@romshark romshark self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants