This repository has been archived by the owner on Apr 17, 2020. It is now read-only.
Create 2-2-stable compatibility #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use address_params not params hash
- Remove old hash rocket format - Use simple colon when you are not interpolating data
|
@heridev Any idea why this wasn't merged in? |
|
@tesserakt I have no idea, but maybe @romul could you answer this question please? I didn't create the pull request into branch 2-2-stable because it doesn't exist or could you create the 2-2-stable and then I can create another pull request? thanks |
|
Added these changes to master and created a Lots of tests are broken in master right now. Could you submit another PR with passing tests? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.