Fix Node.js 4.x compatibility #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue - files in `lib/` are imported within `index.js` which runs directly in Node.js, they were using `let` without specifying strict mode which throws an error in Node 4.x - added `'use strict';` to `lib/difference.js` and `lib/intersection.js` so that the addon works again when using Node 4.x
kevinansfield
added a commit
to TryGhost/Admin
that referenced
this pull request
Jan 29, 2018
no issue - linked directly to compatibility fix commit - PR opened at romulomachado/ember-cli-string-helpers#19
|
@romulomachado please consider merging & re-releasing. This is causing CI to fail for downstream projects (like |
|
@kevinansfield Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
lib/are imported withinindex.jswhich runs directly in Node.js, they were usingletwithout specifying strict mode which throws an error in Node 4.x'use strict';tolib/difference.jsandlib/intersection.jsso that the addon works again when using Node 4.x