Add support for parsing raw string literals #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Jun 5, 2018
src/de/tests.rs
Outdated
| let raw_hashes: String = from_str("r#\"String\"#").unwrap(); | ||
| assert_eq!("String", raw_hashes); | ||
|
|
||
| let raw_hashes_quote: String = from_str("r##\"String with \"#\"##").unwrap(); |
There was a problem hiding this comment.
can we test the multi-line raw strings?
There was a problem hiding this comment.
Sure, I'll add that in.
|
@kvark I've added a test case for multi-line string literals. This PR and the test both preserve carriage returns in string literals, as described in #111 (comment). |
bors bot
added a commit
that referenced
this pull request
Jun 6, 2018
112: Add support for parsing raw string literals r=kvark a=ebkalderon ### Added * Add support for parsing Rust-style raw string literals. ### Changed * Update string unit test to verify string literal deserialization. Fixes #111. Co-authored-by: Eyal Kalderon <ebkalderon@gmail.com>
Build succeeded |
This was referenced Jun 6, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
Fixes #111.