Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update serde version to one that supports 128-bit integers #226

Merged
merged 1 commit into from
May 3, 2020
Merged

Update serde version to one that supports 128-bit integers #226

merged 1 commit into from
May 3, 2020

Conversation

kvark
Copy link
Collaborator

@kvark kvark commented May 2, 2020

r? @CAD97

@CAD97
Copy link
Contributor

CAD97 commented May 2, 2020

Looks fine to me

@kvark
Copy link
Collaborator Author

kvark commented May 2, 2020

bors r=CAD97

bors bot added a commit that referenced this pull request May 2, 2020
@bors @kvark
Merge #226
6f4c6f0 
226: Update serde version to one that supports 128-bit integers r=CAD97 a=kvark

r? @CAD97 

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
@bors
Copy link
Contributor

bors bot commented May 2, 2020

Build failed:

@CAD97
Copy link
Contributor

CAD97 commented May 3, 2020

That's probably because of mixed spaces/tabs in the toml, though why that would be problematic I don't know

@kvark
Update serde version to one that supports 128-bit integers.
7cb8887 
Also fix the struct_integers test and bump the bitflags to the version that compiles.
@kvark
Copy link
Collaborator Author

kvark commented May 3, 2020

my web-based commit was utter garbage 😅
bors r=CAD97

@bors
Copy link
Contributor

bors bot commented May 3, 2020

Build succeeded:

@bors bors bot merged commit b657af9 into master May 3, 2020
@kvark kvark deleted the kvark-serde branch May 3, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kvark @CAD97