Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable restart button if no one wins playing #1

Closed
ron9817 opened this issue Oct 8, 2019 · 3 comments
Assignees

Comments

@ron9817
Copy link
Owner

@ron9817 ron9817 commented Oct 8, 2019

Restart button by default is disabled. Currently is enabled only when a player wins. Need to enable it if game ens up in draw.

@ron9817 ron9817 self-assigned this Oct 8, 2019
@ron9817 ron9817 assigned ron9817 and unassigned ron9817 Oct 8, 2019
@RyanWils

This comment has been minimized.

Copy link

@RyanWils RyanWils commented Oct 8, 2019

Hi I would like to solve this issue

@RyanWils

This comment has been minimized.

Copy link

@RyanWils RyanWils commented Oct 8, 2019

I have submitted a pull request for the above issue.
While I was looking through the code, I noticed an issue with player X.
There's a specific condition if player X wins diagonally then it wont reveal the rematch button and the game wont end
image
If you want I can fix this issue as well and add onto the previous commit

@ron9817

This comment has been minimized.

Copy link
Owner Author

@ron9817 ron9817 commented Oct 9, 2019

Okay please fix the diagonal issue also. Actually in logic i have taken care of that condition also but I think its due to some small syntax or logic mistake the diagonal is not being recognized. In my testing I actually missed this condition. Thank you for finding it.
I am opening a new issue for it.

@ron9817 ron9817 closed this in 7e43c9b Oct 9, 2019
ron9817 added a commit that referenced this issue Oct 9, 2019
Fix #1: Rematch revealed on tie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.