Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Article/network refactor #7

Merged
merged 34 commits into from Jan 6, 2022
Merged

Article/network refactor #7

merged 34 commits into from Jan 6, 2022

Commits on Nov 29, 2021

  1. Update tuist version and Moya

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    c825219 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2021

  1. Remove unused mock, fix header names, fix warning related to deprecat… 

    …ed layer speed for UI testing in the configuration
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    ba31206 View commit details
    Browse the repository at this point in the history

  2. Fix warnings in Haneke

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    f156748 View commit details
    Browse the repository at this point in the history

  3. Fix the swift lint step for the MacBook M1 processor as HomeBrew uses… 

    … a different path for the command
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    1df0800 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2022

  1. Move files and rename module named in header

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    401a0ac View commit details
    Browse the repository at this point in the history

  2. Implement the Combine asynchronous request and update tests and examp… 

    …le app
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    be1ff3a View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2022

  1. Add URLProtocolMock and support in the unit test to read a mock file 

    Add URLSession as parameter into the search service initialiser
Extend the module definition to add a parameter for test resources
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    6fcc080 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Update module names in source header 

    Fix import name in unit test and update file name
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    0970c8b View commit details
    Browse the repository at this point in the history

  2. Replace template with basic test for the next identifier generator

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    27d81af View commit details
    Browse the repository at this point in the history

  3. Add test to validate HTTP 401 Invalid response error condition

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    53e4f05 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Extend URLProtocolMock to use a response struct 

    Add factory method to build the URLSession
Update the tests in the Network module to use the session factory
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    6a6478e View commit details
    Browse the repository at this point in the history

  2. Update the README from master 

    Copy changes from the master branch
    @ronanociosoig
    ronanociosoig committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    6bf3d10 View commit details
    Browse the repository at this point in the history

  3. Fix import statements for Catch example app

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    966e130 View commit details
    Browse the repository at this point in the history

  4. Fix swift lint warnings and errors

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    84ff2e3 View commit details
    Browse the repository at this point in the history

  5. Remove spaces in scheme names

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    a2fb484 View commit details
    Browse the repository at this point in the history

  6. Formatting of the project manifest

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    5b5c287 View commit details
    Browse the repository at this point in the history

  7. Fix swift lint end of line warning

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    e587076 View commit details
    Browse the repository at this point in the history

  8. Update Catch example app and Pokedex app search with Combine implemen… 

    …tation of search
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    3b95dcf View commit details
    Browse the repository at this point in the history

  9. Remove dependency on Moya and Result

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    10bb24b View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Add stubs in the search service for UI testing

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    675baa2 View commit details
    Browse the repository at this point in the history

  2. Add support for async await in the search service

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    004de45 View commit details
    Browse the repository at this point in the history

  3. Improve reliability of UI test by adding waitForExistance with a time… 

    … out
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    36d739b View commit details
    Browse the repository at this point in the history

  4. Move the async testing property to the configuration in the Common mo… 

    …dule
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    da1e0f1 View commit details
    Browse the repository at this point in the history

  5. Fix swift lint paths when running tuist test Pokedex

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    31a02e5 View commit details
    Browse the repository at this point in the history

  6. Improve error naming and testing 

    Simplify function signature for async search service
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    e3203bd View commit details
    Browse the repository at this point in the history

  7. Fix perform request function to use injected session instance 

    Extend unit tests to cover async success and 401 failure
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    f800211 View commit details
    Browse the repository at this point in the history

  8. Fix error in Backpack UI module where it was not loading the image as… 

    …sets
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    8fad2ce View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Add UI test that uses the async network request

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    1a10396 View commit details
    Browse the repository at this point in the history

  2. Rename the custom scheme to AsyncNetworkTesting and pass in a launch … 

    …argument of AsyncTesting
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    341e33c View commit details
    Browse the repository at this point in the history

  3. Add returning mock data when UITesting is passed in the launch arguments

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    008d745 View commit details
    Browse the repository at this point in the history

  4. Refactor the Pokedex app data provider to support both Combine and as… 

    …ync search requests
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    d7bb39f View commit details
    Browse the repository at this point in the history

  5. Improve UI testing by disabling UIView animations and speed up the test 

    Code clean up
    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    68f2c28 View commit details
    Browse the repository at this point in the history

  6. Update the README and images used in it

    @ronan-ociosoig-edo
    ronan-ociosoig-edo committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    37b20e8 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into article/NetworkRefactor

    @ronanociosoig
    ronanociosoig committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    4911594 View commit details
    Browse the repository at this point in the history