Article/network refactor #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed layer speed for UI testing in the configuration
… a different path for the command
Add URLSession as parameter into the search service initialiser Extend the module definition to add a parameter for test resources
Fix import name in unit test and update file name
Add factory method to build the URLSession Update the tests in the Network module to use the session factory
Copy changes from the master branch
Simplify function signature for async search service
Extend unit tests to cover async success and 401 failure
…argument of AsyncTesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dependency on Moya.
Update the networking code to use Combine instead of completion blocks.
Add support for Async/Await search requests with unit tests and UI test.
Replace the custom scheme for networking to one that has Async set as a launch argument and rename it AsyncNetworkTesting.
Fix swift lint issues.