Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article/network refactor #7

Merged
merged 34 commits into from
Jan 6, 2022
Merged

Article/network refactor #7

merged 34 commits into from
Jan 6, 2022

Conversation

ronanociosoig
Copy link
Owner

Remove the dependency on Moya.
Update the networking code to use Combine instead of completion blocks.
Add support for Async/Await search requests with unit tests and UI test.
Replace the custom scheme for networking to one that has Async set as a launch argument and rename it AsyncNetworkTesting.
Fix swift lint issues.

ronan-ociosoig-edo and others added 30 commits November 29, 2021 23:29
…ed layer speed for UI testing in the configuration
Add URLSession as parameter into the search service initialiser
Extend the module definition to add a parameter for test resources
Fix import name in unit test and update file name
Add factory method to build the URLSession
Update the tests in the Network module to use the session factory
Copy changes from the master branch
Simplify function signature for async search service
Extend unit tests to cover async success and 401 failure
@ronanociosoig ronanociosoig merged commit de5adb9 into master Jan 6, 2022
@ronanociosoig ronanociosoig deleted the article/NetworkRefactor branch January 6, 2022 22:53
@ronanociosoig ronanociosoig restored the article/NetworkRefactor branch January 17, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants