Monkey patch ember-cli's Builder.prototype.build. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with the ember-cli Builder.prototype.build implementation for 0.1.3 and 0.1.4. The bug was fixed in ember-cli/ember-cli#2792 and will be availabe in 0.1.5. Once that version is published and in normal usage this monkey patch can be removed.
rwjblue
force-pushed
the
monkey-patch-builder-build
branch
from
11be6d2
to
af62409
Compare
|
LGTM We could merge this, release 0.0.5 and then require 0.0.5 in the ruby gem, so it'll fix thoughtbot/ember-cli-rails#31 |
rondale-sc
added a commit
that referenced
this pull request
Dec 21, 2014
Monkey patch ember-cli's Builder.prototype.build.
|
+1 [edit] Version 0.0.5 has been pushed and tagged https://github.com/rondale-sc/ember-cli-rails-addon/tree/v0.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the ember-cli Builder.prototype.build implementation for 0.1.3 and 0.1.4. The bug was fixed in ember-cli/ember-cli#2792 and will be availabe in 0.1.5. Once that version is published and in normal usage this monkey patch can be removed.