Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ./tmp dir exists #8

Merged
merged 2 commits into from
Jan 25, 2015
Merged

Ensure ./tmp dir exists #8

merged 2 commits into from
Jan 25, 2015

Conversation

jesenko
Copy link
Contributor

@jesenko jesenko commented Jan 25, 2015

Building of ember app fails if ./tmp folder within ember-cli root does not exist as build.lock file cannot be created.

Normally ./tmp folder is created in ember-cli build process; if ember-cli-rails-addon is added prior to first successful build, ./tmp folder does not yet exist.

This PR ensures that tmp folder exists. It also fixes some syntax errors related to scoping of variables introduced in previous commit.

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 25, 2015

👍

rwjblue added a commit that referenced this pull request Jan 25, 2015
@rwjblue rwjblue merged commit 3df027f into rondale-sc:master Jan 25, 2015
@rwjblue
Copy link
Collaborator

rwjblue commented Jan 25, 2015

@rondale-sc - Should be ready for release when you have a chance.

@rondale-sc
Copy link
Owner

@rwjblue Sounds good. It'll have to be updated in ember-cli-rails also. /cc @rwz

[edit] 0.0.10 released and tagged

}
},
tmpDir: function() {
path.join(process.cwd(), 'tmp');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be return here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure...I messed it up when doing rebase for the PR...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, WHOOPS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad, should have tested the final version of PR 😳

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesenko - Mind submitting a fixing PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did, PR #9
On 25 Jan 2015, at 18:32, Robert Jackson notifications@github.com wrote:

In index.js:

 }

},

  • lockfilePath: function() {
  • return path.join(process.cwd(), 'tmp', 'build.lock');
  • ensureTmp: function() {
  • var dir = this.tmpDir();
  • if (!fs.existsSync(dir)){
  •  fs.mkdirSync(dir);
    
  • }
  • },
  • tmpDir: function() {
  • path.join(process.cwd(), 'tmp');
    @jesenko - Mind submitting a fixing PR?


Reply to this email directly or view it on GitHub.

@jesenko jesenko mentioned this pull request Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants