Skip to content
This repository has been archived by the owner on Feb 22, 2021. It is now read-only.

Add a cpp-options workaround for windows #4

Merged
merged 1 commit into from
May 27, 2017
Merged

Add a cpp-options workaround for windows #4

merged 1 commit into from
May 27, 2017

Conversation

Mikolaj
Copy link

@Mikolaj Mikolaj commented May 27, 2017

This is an implementation of this hack: haskell-game/sdl2#139
It compiles fine on Linux and fixes compilations on Widows (appveyor).

@Mikolaj
Copy link
Author

Mikolaj commented May 27, 2017

BTW, is it possible to enable github issues for this project? BTW, thank you for you work, really appreciated!

@rongcuid
Copy link
Owner

Issues enabled.

@rongcuid rongcuid merged commit 47a4ca0 into rongcuid:master May 27, 2017
@Mikolaj
Copy link
Author

Mikolaj commented May 27, 2017

Thank you very much. I was thinking, would it make sense to approach the haskell-game people, move your fork there as the main sdl2-ttf repo and then you'd take over sdl2-ttf officially and not as an interim maintainer as it is now? From what I can see, @osa1 is perfectly fine with that: https://github.com/osa1/hsSDL2-ttf/issues/5#issuecomment-244425676

@rongcuid
Copy link
Owner

I am not really doing any game programming recently, but I can take this package (for I might still need it later). Pull requests are fine for me, though.

@Mikolaj
Copy link
Author

Mikolaj commented May 27, 2017

@polarina, @jmcarthur, others: would it make sense to include sdl2-ttf into haskell-game and invite @rongcuid to the team, or would the package be better off as a standalone package maintained by @rongcuid exclusively?
@mankyKitty, @osa1: your thoughts?

BTW, thank you all for your great work on this stuff.

@osa1
Copy link

osa1 commented May 28, 2017

I'm no longer involved in sdl2-ttf development but since you asked I think it's a good idea to move sdl2-ttf to haskell-game because (1) everyone in the organization can maintain this package (2) it might be good idea to develop this package with sdl2 because these two packages need to be used together (unless there's another sdl2 wrapper that I'm not aware of).

@mankyKitty
Copy link

@osa1 sums it up nicely I think, moving it to haskell-game seems like the best plan. What's needed from me to transfer it over?

@Mikolaj
Copy link
Author

Mikolaj commented May 28, 2017

@ocharles: ^^^? :)

@Mikolaj
Copy link
Author

Mikolaj commented May 29, 2017

Oh, I've just stumbled upon https://github.com/sbidin/sdl2-ttf. How do these projects compare?

Edit: I guess it's not on hackage, but then I see it has come sensible optimizations that are also probably more robust wrt char enconding on Windows/Wine:
https://github.com/sbidin/sdl2-ttf/blob/master/src/SDL/Font.hs#L223
https://github.com/sbidin/sdl2-ttf/blob/master/src/SDL/Font.hs#L244
I wonder if we could get the best of both worlds (and on haskell-game, preferably).

@ocharles
Copy link

I've forked the repository to @haskell-game. Please open an issue on that repository for people who should have access to it.

@Mikolaj
Copy link
Author

Mikolaj commented May 29, 2017

@ocharles: thank you, but actually you have to enable issues on that fork first. :)

@Mikolaj
Copy link
Author

Mikolaj commented May 29, 2017

@ocharles: or just add me to the team and I will sort it out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants