Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Web::Spider specs #66

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Add Web::Spider specs #66

merged 3 commits into from
Jun 8, 2024

Conversation

AI-Mozi
Copy link
Member

@AI-Mozi AI-Mozi commented Aug 8, 2023

#38

postmodern
postmodern requested changes Aug 9, 2023
View reviewed changes
spec/builtin/web/spider_spec.rb Outdated Show resolved Hide resolved
@AI-Mozi AI-Mozi force-pushed the add_web_spider_specs branch 2 times, most recently from d8a06a2 to 5ae8435 Compare May 2, 2024 09:15
@AI-Mozi AI-Mozi requested a review from postmodern May 2, 2024 09:16
postmodern
postmodern requested changes May 2, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should either tag the specs that require network access with :network, or use webmock/rspec + sinatra to redirect HTTP requests to an example Sinatra app in the specs that we control.

spec/builtin/web/spider_spec.rb Outdated Show resolved Hide resolved
spec/builtin/web/spider_spec.rb Outdated Show resolved Hide resolved
postmodern
postmodern requested changes May 3, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want to spider all of www.google.com? Also I'm pretty sure Google will change that last URL and it will eventually break the specs.

We will need to find a safer website that last < 10 pages to test against.

@AI-Mozi
Copy link
Member Author

AI-Mozi commented May 4, 2024

Ugh.. you're right, it's not the best choice

@postmodern postmodern merged commit 9114305 into ronin-rb:main Jun 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postmodern postmodern postmodern requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AI-Mozi @postmodern