Issue 4 proper handling of k 1 encoding #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime Lubin <maxime.lubin@scality.com>
Signed-off-by: Maxime Lubin <maxime.lubin@scality.com>
Encoding the single parity of k+1 code is XORing all data parts with the existing, potentially random and unitilized content of the parity buffer. Do a copy first, then XOR all the rest. Signed-off-by: Maxime Lubin <maxime.lubin@scality.com>
lamphamsy
approved these changes
Aug 9, 2018
jorangreef
requested changes
Aug 13, 2018
| dot_cpy(shards[i], target, shardSize); | ||
| copied = 1; | ||
| } else { | ||
| dot_xor(shards[i], target, shardSize); |
There was a problem hiding this comment.
Would you please update the indentation before dot_xor() to be the same as the indentation before dot_cpy()?
Indentation should use 2 spaces, no tabs.
| @@ -317,7 +317,7 @@ queue.onData = function(args, end) { | |||
| ); | |||
| var buffer = cipher.update(Buffer.alloc(bufferOffset + bufferSize)); | |||
| Assert(buffer.length === bufferOffset + bufferSize); | |||
| var parity = Buffer.alloc(parityOffset + paritySize); | |||
| var parity = Node.crypto.randomBytes(parityOffset + paritySize); | |||
There was a problem hiding this comment.
Please would you use this instead:
var parity = cipher.update(Buffer.alloc(parityOffset + paritySize));
The AES cipher is faster than a call to crypto.randomBytes(), saving around 2 seconds (10%) of total runtime, for the same guarantees.
| @@ -360,10 +360,6 @@ queue.onData = function(args, end) { | |||
| for (var i = 0; i < k; i++) Assert(Hash(shards[i]) === hashes[i]); | |||
| for (var i = k; i < k + m; i++) hashes[i] = Hash(shards[i]); | |||
| // Test against fixed vector: | |||
| var key = ''; | |||
There was a problem hiding this comment.
Thanks for removing this artifact.
| @@ -764,6 +760,6 @@ queue.concat([ | |||
| [24, 5, 13, 9, 8, '4968f6d39f355c41e006b754b436d823'], | |||
| [24, 5, 4, 12, 89816, '93e82c3652f9f963eed72e0d640d9528'], | |||
| [24, 6, 10, 5, 8, '1cd9f45259767305dd7b565bcf9c0359'], | |||
| [24, 6, 3, 1, 164320, 'f2fad94fdb9e4518728cb0a5a5dbe392'] | |||
| [24, 6, 3, 1, 164320, 'f2fad94fdb9e4518728cb0a5a5dbe392'], | |||
There was a problem hiding this comment.
Would you please remove the trailing comma that was added here?
|
Thanks @maximelubin , I made the requested PR changes already in another PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoding the single parity of k+1 code is XORing all data parts with the existing, potentially random and uninitialized content of the parity buffer.
Do a copy first, then XOR all the rest.