Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with splitting defined named #277

Closed
wants to merge 4 commits into from

Conversation

rogsmith
Copy link

When trying to call doc.labels, I was receiving exception: NoMethodError: undefined method `split' for nil:NilClass because the defined_name.text was not in the format expected.

@stevendaniels
Copy link
Contributor

Thanks for the PR.

This certainly prevents the error in #276 from being raised, but it doesn't fix the issue. I'd still like to understand what's going wrong in your case, write a test case for the situation and apply an appropriate fix.

If you look at the comments for that method, it's clear it's looking for a defined name similar to this value: "Sheet1!$C$5". My first question is what is your defined_name's value? Then, I'd want to figure out if your defined_name's value is a valid value for that field (some XLSX generators make mistakes). If it is a valid value for that field, then we'd start looking for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants