Excelx::Relationships responds to #to_h rather than #to_a #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage decreased (-0.4%) to 93.994% when pulling 5f975f3178691e9bef26a55758377ef0b6e89ddc on default-relationships into 1cbfe72 on master. |
Empact
force-pushed
the
default-relationships
branch
from
5f975f3
to
3513dc0
Compare
|
Coverage decreased (-0.4%) to 93.994% when pulling 3513dc03485d040a4289810ae4c32d1bd87fe8b8 on default-relationships into 1cbfe72 on master. |
Roo::Excelx::Relationships#extract_relationshipts
As it returns a hash.
Empact
force-pushed
the
default-relationships
branch
from
3513dc0
to
9dd3c01
Compare
|
Since this is technically a breaking change, I think we should hold off on this PR until v3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And consistently returns a hash.
This is a more reasonable api given the return values.