Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subset level by values with method=nearest #262

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

cehbrecht
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes issue #xyz
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
  • I have added my relevant user information to AUTHORS.md
  • What kind of change does this PR introduce?:
    Bug fix

  • Does this PR introduce a breaking change?:
    No

  • Other information:

subset_level_by_values didn't work for CMIP6 dataset. Needed to add method="nearest" to ds.sel to make it work.

The example notebook (Process error: Requested levels include some not found in the dataset: 1000.0):
https://nbviewer.org/github/roocs/rooki/blob/master/notebooks/demo/rook-errors-2022-12-08.ipynb

@cehbrecht cehbrecht self-assigned this Dec 12, 2022
@cehbrecht cehbrecht merged commit e5ab2eb into master Dec 12, 2022
@cehbrecht cehbrecht deleted the fix-subset-level-by-values branch December 12, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants