fix check_levels_exist decorator #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2022
Merged
sol1105
approved these changes
Dec 14, 2022
| @@ -286,7 +286,8 @@ def func_checker(*args, **kwargs): | |||
|
|
|||
| req_levels = set(kwargs.get("level_values", set())) | |||
| da_levels = xu.get_coord_by_type(da, "level") | |||
| levels = {lev for lev in da_levels.values} | |||
| # round levels to precision 4. There might be level values like 1000.00000001 ... which would not match to 1000 | |||
| levels = {round(lev, 4) for lev in da_levels.values} | |||
There was a problem hiding this comment.
In the remapping part we introduce in the roocs.ini
[clisops:coordinate_precision]
hor_coord_decimals = 6
vert_coord_decimals = 6
In the remapping PR I can then substitute levels = {round(lev, 4) for lev in da_levels.values} with levels = {round(lev, CONFIG["clisops:coordinate_precision"]["vert_coord_decimals"]) for lev in da_levels.values} (and set it to 4 in the roocs.ini). What do you think?
There was a problem hiding this comment.
@sol1105 sounds good to use a config for the precision.
@sol1105 @Zeitsperre
Should we have a cleansing module to fix datasets when reading and writing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
AUTHORS.mdWhat kind of change does this PR introduce?:
bug fix
Does this PR introduce a breaking change?:
no
Other information:
This PR is a follow up fix for PR fix subset level by values with method=nearest #262. It fixes the
check_levels_existdecorator to handle level values like 1000.00000001. It rounds them to precision 4 to match them with the correct value 1000.0.