-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use platformdirs #323
Use platformdirs #323
Conversation
Pull Request Test Coverage Report for Build 7898546444Details
💛 - Coveralls |
…dule to support suggested versions
@Zeitsperre @sol1105 when using |
@cehbrecht I suppose you technically could. I've set it up so that if the option is not provided, it'll use a cached location, but if you'd rather remove this option entirely, you should be able to work with locations provided uniquely by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great, thank you.
In the regrid notebook of the documentation, I used the explicit path instead of the CONFIG settings. I will update that
https://clisops--323.org.readthedocs.build/en/323/notebooks/regrid.html#Local-weights-cache
In general I wonder, whether the ./binder/environment.yml
and ./docs/environment.yml
are too extensive. Should they only include packages additionally required with regards to the basic ./environment.yml
?
Pull Request Checklist:
AUTHORS.md
What kind of change does this PR introduce?:
platformdirs
to set a default platform-dependent location in the event that one is not provided forlocal_weights_dir
.platformdirs
now handles the caching location for testing data.require_module
now handles supported module version information.2023.03
→2023.3
)Does this PR introduce a breaking change?:
Yes. The default location hard-set in the
roocs.ini
configuration has been removed.Additionally, the
.clisops_testing_data
folder can be removed from your$HOME
folder. This is now saved to$HOME/.cache/clisops
on *nix.Other information:
On Linux, this looks like: