build: update go modules #12663
Merged
build: update go modules #12663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlaineEXE
requested review from
travisn and
subhamkrai
and removed request for
travisn
BlaineEXE
commented
Aug 3, 2023
go.mod
Outdated
| github.com/kubernetes-incubator/external-storage => github.com/libopenstorage/external-storage v0.20.4-openstorage-rc3 | ||
| github.com/portworx/sched-ops => github.com/portworx/sched-ops v0.20.4-openstorage-rc3 | ||
| ) | ||
| replace github.com/googleapis/gnostic => github.com/googleapis/gnostic v0.4.1 |
There was a problem hiding this comment.
I tried updating this as well with no success. The latest is github.com/google/gnostic v0.6.9.
BlaineEXE
force-pushed
the
update-go-mod
branch
from
1662eff
to
33ccdc8
Compare
subhamkrai
reviewed
Aug 7, 2023
There was a problem hiding this comment.
I think the build issues could be resolved by applying anyone of the last two comment kubernetes/client-go#1084
#12672 will probably fix this issue |
BlaineEXE
force-pushed
the
update-go-mod
branch
5 times, most recently
from
4f0cf28
to
2dae2ec
Compare
|
@BlaineEXE ready to rebase? |
|
This pull request has merge conflicts that must be resolved before it can be merged. @BlaineEXE please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork |
7 tasks
BlaineEXE
force-pushed
the
update-go-mod
branch
2 times, most recently
from
a059333
to
5452635
Compare
Update go modules. The primary goal is to remove the goproxy import which has security warnings. The library is not used directly or indirectly by any called Rook code, only dependency modules. Therefore, exclude it from the build. At the same time, portworx deps are starting to complicate the module update again. Rook also doesn't directly or indirectly use the portworx code, so exclude it also. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
BlaineEXE
force-pushed
the
update-go-mod
branch
from
5452635
to
87fc552
Compare
travisn
approved these changes
Aug 22, 2023
mergify bot
added a commit
that referenced
this pull request
Aug 23, 2023
build: update go modules (backport #12663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go modules. The primary goal is to remove the goproxy import which has security warnings. The library is not used directly or indirectly by any called Rook code, only dependency modules. Therefore, exclude it from the build.
At the same time, portworx deps are starting to complicate the module update again. Rook also doesn't directly or indirectly use the portworx code, so exclude it also.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-cion the PR.