Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: move discovery daemon settings into the configmap #12840

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

smuth4
Copy link
Contributor

@smuth4 smuth4 commented Sep 2, 2023

Description of your changes:

This allows the rook mgr module to check if the discovery daemon is enabled here: https://github.com/ceph/ceph/blob/6dda3e2b432bf9b55dd0db004b3ea6793333d66f/src/pybind/mgr/rook/rook_cluster.py#L763C49-L763C49. The udev blacklist setting was also moved just to keep similar settings in the same place.

Which issue is resolved by this Pull Request:
None

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • [N/A]] Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • [N/A]] Pending release notes updated with breaking and/or notable changes for the next minor release.
  • [N/A] Documentation has been updated, if necessary.
  • [N/A] Unit tests have been added, if necessary.
  • [N/A] Integration tests have been added, if necessary.

This allows the rook mgr module to check if the discovery daemon is enabled. The udev blacklist setting was also moved just to keep similar settings in the same place.

Signed-off-by: Stephen Muth <smuth4@gmail.com>
@travisn travisn merged commit 3e248bf into rook:master Sep 5, 2023
47 of 50 checks passed
mergify bot added a commit that referenced this pull request Sep 6, 2023
helm: move discovery daemon settings into the configmap (backport #12840)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants