-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix discover daemonset default value for discovery interval #12844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbailleul
force-pushed
the
fix_discover
branch
2 times, most recently
from
September 4, 2023 09:00
2a1ca6b
to
79c72f6
Compare
subhamkrai
reviewed
Sep 4, 2023
subhamkrai
reviewed
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits. Thanks
travisn
requested changes
Sep 5, 2023
This pull request has merge conflicts that must be resolved before it can be merged. @lbailleul please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork |
lbailleul
force-pushed
the
fix_discover
branch
from
September 6, 2023 08:04
79c72f6
to
b71c4a6
Compare
travisn
requested changes
Sep 6, 2023
Correctly set discoveryInterval default value by passing defaultDiscoverInterval to k8sutil.GetValue Allow to set ROOK_DISCOVER_DEVICES_INTERVAL env var through discoveryDaemonInterval helm value Signed-off-by: Louis Bailleul <louis.bailleul@pgs.com>
lbailleul
force-pushed
the
fix_discover
branch
from
September 7, 2023 09:28
b71c4a6
to
e56122c
Compare
travisn
approved these changes
Sep 7, 2023
mergify bot
added a commit
that referenced
this pull request
Sep 7, 2023
Fix discover daemonset default value for discovery interval (backport #12844)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Fix the default value passed to the discovery deamonset by the operator and add a configuration variable
discoveryDaemonInterval
to the Helm chartCurrently the daemonset pods crash with the error below, this is due to the operator not properly setting a default value when the
ROOK_DISCOVER_DEVICES_INTERVAL
env variable is not set.Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-ci
on the PR.