Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discover daemonset default value for discovery interval #12844

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

lbailleul
Copy link
Contributor

Description of your changes:
Fix the default value passed to the discovery deamonset by the operator and add a configuration variable discoveryDaemonInterval to the Helm chart

Currently the daemonset pods crash with the error below, this is due to the operator not properly setting a default value when the ROOK_DISCOVER_DEVICES_INTERVAL env variable is not set.

Error: invalid argument "" for "--discover-interval" flag: time: invalid duration ""
   Usage:  rook discover [flags]

Flags:
rook error: invalid argument "" for "--discover-interval" flag: time: invalid duration ""
        --discover-interval duration   interval between discovering devices (default 60m) (default 1h0m0s)  
  -h, --help                                      help for discover      
        --use-ceph-volume                 Use ceph-volume inventory to extend storage devices information (default false)
Global Flags:      
       --log-level string   logging level for logging/tracing output (valid values: ERROR,WARNING,INFO,DEBUG) (default "INFO")

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • [] Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • [] Pending release notes updated with breaking and/or notable changes for the next minor release.
  • [] Documentation has been updated, if necessary.
  • [] Unit tests have been added, if necessary.
  • [] Integration tests have been added, if necessary.

@lbailleul lbailleul force-pushed the fix_discover branch 2 times, most recently from 2a1ca6b to 79c72f6 Compare September 4, 2023 09:00
Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits. Thanks

deploy/charts/rook-ceph/values.yaml Outdated Show resolved Hide resolved
Documentation/Helm-Charts/operator-chart.md Outdated Show resolved Hide resolved
pkg/operator/discover/discover.go Show resolved Hide resolved
@mergify
Copy link

mergify bot commented Sep 5, 2023

This pull request has merge conflicts that must be resolved before it can be merged. @lbailleul please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

deploy/charts/rook-ceph/templates/deployment.yaml Outdated Show resolved Hide resolved
pkg/operator/discover/discover.go Show resolved Hide resolved
Correctly set discoveryInterval default value by passing defaultDiscoverInterval to k8sutil.GetValue
Allow to set ROOK_DISCOVER_DEVICES_INTERVAL env var through discoveryDaemonInterval helm value

Signed-off-by: Louis Bailleul <louis.bailleul@pgs.com>
@travisn travisn merged commit 7fbb4cc into rook:master Sep 7, 2023
49 of 50 checks passed
mergify bot added a commit that referenced this pull request Sep 7, 2023
Fix discover daemonset default value for discovery interval (backport #12844)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants