Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new CephObjectStore GetPort method for RGW service #8141

Closed
BlaineEXE opened this issue Jun 17, 2021 · 0 comments · Fixed by #8244
Closed

Use new CephObjectStore GetPort method for RGW service #8141

BlaineEXE opened this issue Jun 17, 2021 · 0 comments · Fixed by #8244
Labels
ceph main ceph tag ceph-rgw object Object protocol - S3
Projects
v1.7

Comments

@BlaineEXE
Copy link
Member

Replace setObjectStorePort() with this function, currently, that function chose port from rgw svc and picks the first port, Other part of the code prefers for TLS, if it is enabled so for OBC's we end up having https endpoint with non-secure port.

Originally posted by @thotz in #8112 (comment)
@BlaineEXE BlaineEXE added this to To do in v1.7 via automation Jun 17, 2021
@BlaineEXE BlaineEXE added ceph main ceph tag ceph-rgw object Object protocol - S3 labels Jun 17, 2021
@BlaineEXE BlaineEXE mentioned this issue Jun 17, 2021
Merged
10 tasks
thotz added a commit to thotz/rook that referenced this issue Jul 2, 2021
@thotz
ceph: fetch rgw port from cephobjectstore crd for obc
cca4394 
Currently `setObjectStorePort()` queries port from RGW service and
picks up the first port from the list, other places of the code
prefers for TLS, if it is enabled so for OBC's we end up having
`https` endpoint with non-secure port.

Fixes: rook#8141
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
@thotz thotz mentioned this issue Jul 2, 2021
Merged
10 tasks
thotz added a commit to thotz/rook that referenced this issue Jul 5, 2021
@thotz
ceph: fetch rgw port from cephobjectstore crd for obc
e4a9b4b 
Currently `setObjectStorePort()` queries port from RGW service and
picks up the first port from the list, other places of the code
prefers for TLS, if it is enabled so for OBC's we end up having
`https` endpoint with non-secure port.

Fixes: rook#8141
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
v1.7 automation moved this from To do to Done Jul 5, 2021
mergify bot pushed a commit that referenced this issue Jul 5, 2021
@thotz
ceph: fetch rgw port from cephobjectstore crd for obc
9be2049 
Currently `setObjectStorePort()` queries port from RGW service and
picks up the first port from the list, other places of the code
prefers for TLS, if it is enabled so for OBC's we end up having
`https` endpoint with non-secure port.

Fixes: #8141
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
(cherry picked from commit e4a9b4b)
thotz added a commit that referenced this issue Jul 6, 2021
@thotz
ceph: fetch rgw port from cephobjectstore crd for obc
5cb3926 
Currently `setObjectStorePort()` queries port from RGW service and
picks up the first port from the list, other places of the code
prefers for TLS, if it is enabled so for OBC's we end up having
`https` endpoint with non-secure port.

Fixes: #8141
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
(cherry picked from commit e4a9b4b)
subhamkrai pushed a commit to subhamkrai/rook that referenced this issue Oct 1, 2021
@thotz @subhamkrai
ceph: fetch rgw port from cephobjectstore crd for obc
d56d0ea 
Currently `setObjectStorePort()` queries port from RGW service and
picks up the first port from the list, other places of the code
prefers for TLS, if it is enabled so for OBC's we end up having
`https` endpoint with non-secure port.

Fixes: rook#8141
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ceph main ceph tag ceph-rgw object Object protocol - S3
Projects
No open projects
v1.7
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ceph: fetch rgw port from cephobjectstore crd for obc thotz/rook
1 participant
@BlaineEXE