Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: fetch rgw port from cephobjectstore crd for obc #8244

Merged
merged 1 commit into from Jul 5, 2021
Merged

ceph: fetch rgw port from cephobjectstore crd for obc #8244

merged 1 commit into from Jul 5, 2021

Conversation

thotz
Copy link
Contributor

@thotz thotz commented Jul 2, 2021

Currently setObjectStorePort() queries port from RGW service and
picks up the first port from the list, other places of the code
prefers for TLS, if it is enabled so for OBC's we end up having
https endpoint with non-secure port.

Fixes: #8141
Signed-off-by: Jiffin Tony Thottan thottanjiffin@gmail.com

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@mergify mergify bot added the ceph main ceph tag label Jul 2, 2021
travisn
travisn reviewed Jul 2, 2021
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an unused function now that can be removed

@thotz
ceph: fetch rgw port from cephobjectstore crd for obc
e4a9b4b 
Currently `setObjectStorePort()` queries port from RGW service and
picks up the first port from the list, other places of the code
prefers for TLS, if it is enabled so for OBC's we end up having
`https` endpoint with non-secure port.

Fixes: rook#8141
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
@thotz
Copy link
Contributor Author

thotz commented Jul 5, 2021

LGTM, just an unused function now that can be removed

Done

@thotz thotz requested a review from travisn July 5, 2021 05:44
@leseb leseb merged commit 97f1cc3 into rook:master Jul 5, 2021
@mergify mergify bot mentioned this pull request Jul 5, 2021
Merged
mergify bot added a commit that referenced this pull request Jul 7, 2021
@mergify
Merge pull request #8260 from rook/mergify/bp/release-1.6/pr-8244
c3a811c 
ceph: fetch rgw port from cephobjectstore crd for obc (backport #8244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

@travisn travisn Awaiting requested review from travisn

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use new CephObjectStore GetPort method for RGW service
3 participants
@thotz @leseb @travisn