rook cluster helm chart no longer deploys an ingress on k8s 1.17 #9174
Labels
Comments
TomHellier
pushed a commit
to TomHellier/rook
that referenced
this issue
Nov 15, 2021
The ingress api version changed when it went to v1, and this has caused a lot of problems on how this is handled across the helm ecosystem. This commit uses the standard introduced by bitnami to deal with overriding the ingress version. Closes rook#9174 Signed-off-by: Tom H <me@tomhellier.com>
10 tasks
TomHellier
pushed a commit
to TomHellier/rook
that referenced
this issue
Nov 15, 2021
The ingress api version changed when it went to v1, and this has caused a lot of problems, on how this is handled across the helm ecosystem. This commit uses the standard introduced by bitnami to deal with overriding the ingress version. Closes rook#9174 Signed-off-by: Tom H <me@tomhellier.com>
TomHellier
pushed a commit
to TomHellier/rook
that referenced
this issue
Nov 15, 2021
The ingress api version changed when it went to v1, and this has caused a lot of problems, on how this is handled across the helm ecosystem. This commit uses the standard introduced by bitnami to deal with overriding the ingress version. Closes rook#9174 Signed-off-by: Tom H <me@tomhellier.com>
TomHellier
pushed a commit
to TomHellier/rook
that referenced
this issue
Nov 15, 2021
The ingress api version changed when it went to v1, and this has caused a lot of problems, on how this is handled across the helm ecosystem. This commit uses the standard introduced by bitnami to deal with overriding the ingress version. Closes rook#9174 Signed-off-by: Tom H <me@tomhellier.com>
TomHellier
pushed a commit
to TomHellier/rook
that referenced
this issue
Nov 15, 2021
The ingress api version changed when it went to v1, and this has caused a lot of problems, on how this is handled across the helm ecosystem. This commit uses the standard introduced by bitnami to deal with overriding the ingress version. Closes rook#9174 Signed-off-by: Tom H <me@tomhellier.com>
TomHellier
pushed a commit
to TomHellier/rook
that referenced
this issue
Nov 15, 2021
The ingress api version changed when it went to v1, and this has caused a lot of problems, on how this is handled across the helm ecosystem. This commit uses the standard introduced by bitnami to deal with overriding the ingress version. Closes rook#9174 Signed-off-by: Tom H <me@tomhellier.com>
TomHellier
pushed a commit
to TomHellier/rook
that referenced
this issue
Nov 15, 2021
The ingress api version changed when it went to v1, and this has caused a lot of problems, on how this is handled across the helm ecosystem. This commit uses the standard introduced by bitnami to deal with overriding the ingress version. Closes rook#9174 Signed-off-by: Tom H <me@tomhellier.com>
|
@TomHellier What is your values.yaml? The Rook CI runs on various K8s versions back to 1.15 and the helm tests are currently passing. For example, on the latest release-1.7 build, the helm test is passing on 1.16 as seen here. Perhaps it is related to the helm version? The Rook CI is using v3.6.2. What version are you using? |
|
@travisn from my recollection of the ceph helm tests, they deploy the cephcluster crds etc, but do not deploy an ingress. I think this is because the minikube in the integration tests does not support this, I spent some time yesterday investigating what would be required to get some integration test coverage for this bug, I think we can add an ingress addon to minikube when it starts, and define an ingress as shown in this commit on my fork I ran out of time yesterday and was not able to look at it today. I'll do some further investigations tomorrow. I've updated the issue to be more clear the failure to deploy relates to an ingress. |
TomHellier
changed the title
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 17, 2021
the ingress for the ceph-cluster helm chart wasn't previously tested Closes rook#9174 Signed-off-by: Tom H <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 17, 2021
the ingress for the ceph-cluster helm chart wasn't previously tested Closes rook#9174 Signed-off-by: Tom H <me@tomhellier.com> Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 17, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 17, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 17, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
|
Ah, makes sense that it is only related to ingress that isn't in the CR. |
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 19, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 22, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
mergify bot
pushed a commit
that referenced
this issue
Nov 23, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes #9174 Signed-off-by: Tom Hellier <me@tomhellier.com> (cherry picked from commit ba44602) # Conflicts: # .github/workflows/integration-test-setup/action.yaml # .github/workflows/setup-cluster-resources/action.yaml
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 24, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com> (cherry picked from commit ba44602)
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 24, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com> (cherry picked from commit ba44602)
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 29, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com> (cherry picked from commit ba44602)
TomHellier
added a commit
to TomHellier/rook
that referenced
this issue
Nov 29, 2021
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com> (cherry picked from commit ba44602) Signed-off-by: Tom Hellier <me@tomhellier.com>
10 tasks
parth-gr
pushed a commit
to parth-gr/rook
that referenced
this issue
Feb 22, 2022
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
parth-gr
pushed a commit
to parth-gr/rook
that referenced
this issue
Feb 22, 2022
The ingress api version changed when it went to v1, and this has caused some upheaval throughout the kubernetes ecosystem. This commit uses a common method of deciding which ingress api to use, and allows the optional override of the kubernetes version presented to helm using the helm build-in capabilities. also add an ingress into the helm integration tests so any regressions to how ingresses are handled in the future are caught easier. Closes rook#9174 Signed-off-by: Tom Hellier <me@tomhellier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a bug report or feature request?
Deviation from expected behavior:
It should be possible to deploy to k8s 1.17 with an ingress.
Expected behavior:
Deploying the helm chart using argocd 2.1 fails to deploy an ingress resource due to an error introduced in rook v1.7.3 with #8666
evaluating to true on 1.17 due to networking.k8s.io/v1 containing the NetworkPolicy
see similar issue elsewhere on the internet:
https://gitea.com/gitea/helm-chart/issues/77
I think it would be good to provide similar options elsewhere like other opensource charts in the helm ecosystem, so you can override this setting entirely.
Environment:
uname -a): n/arook versioninside of a Rook Pod): 1.7.7ceph -v): n/akubectl version): 1.17ceph healthin the Rook Ceph toolbox): n/aThe text was updated successfully, but these errors were encountered: