ceph: add networking.k8s.io/v1 Ingress chart compatability #8666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
requested changes
Sep 9, 2021
Kubernetes cluster versions 1.22+ must use the v1 Ingress version. Signed-off-by: Bryton Hall <email@bryton.io>
|
@leseb, good catch! Fixed. |
leseb
reviewed
Sep 9, 2021
| {{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1" }} | ||
| {{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1" }} | ||
| apiVersion: networking.k8s.io/v1 | ||
| {{ else if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1" }} | ||
| apiVersion: networking.k8s.io/v1beta1 | ||
| {{ else }} | ||
| apiVersion: extensions/v1beta1 |
There was a problem hiding this comment.
Depends on which k8s versions rook supports. networking.k8s.io/v1 was introduced in 1.19 and networking.k8s.io/v1beta1 was introduced in 1.14. Do we want to keep the latter to support <1.19 or remove it and force those users install an older version of the chart?
There was a problem hiding this comment.
I meant this one apiVersion: extensions/v1beta1
There was a problem hiding this comment.
Ah, yeah. That one's pretty old but the docs say 1.11 is the minimum supported version so it should probably stay.
leseb
approved these changes
Sep 9, 2021
travisn
added a commit
that referenced
this pull request
Sep 9, 2021
ceph: add networking.k8s.io/v1 Ingress chart compatability (backport #8666)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes cluster versions 1.22+ must use the v1 Ingress version.
Signed-off-by: Bryton Hall email@bryton.io
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.