osd: only set kek to env var on encryption scenario #10035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a corner case where an env variable populated with the prepare job could influence and trigger some encryption code. We have an env variable to discover whether the prepare job will encrypt a drive or not so let's use that instead of running code as a noop and sometimes trigger a corner case. In this scenario, the prepare job had an "IBM_" env variable present in the OS image (IBM OS) so the setKEKinEnv() function would get called for no reason. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
fix-ibm-kms-corner-case
branch
from
668f689
to
6bc7827
Compare
BlaineEXE
approved these changes
Apr 11, 2022
travisn
approved these changes
Apr 11, 2022
This was referenced Apr 11, 2022
mergify bot
added a commit
that referenced
this pull request
Apr 11, 2022
osd: only set kek to env var on encryption scenario (backport #10035)
travisn
added a commit
that referenced
this pull request
Apr 11, 2022
osd: only set kek to env var on encryption scenario (backport #10035)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
There is a corner case where an env variable populated with the prepare
job could influence and trigger some encryption code. We have an env
variable to discover whether the prepare job will encrypt a drive or not
so let's use that instead of running code as a noop and sometimes
trigger a corner case. In this scenario, the prepare job had an 'IVM_'
env variable present in the OS image (IBM OS) so the setKEKinEnv()
function would get called for no reason.
Signed-off-by: Sébastien Han seb@redhat.com
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-cion the PR.