ci: enable and fixes for nfs ci #10510

Rakshith-R · 2022-06-27T09:48:28Z

This commit anabled nfs csi ci and
add fixes/improvements to it like the
following:

verify deletion of cephnfs and .nfs pool before proceeding
verify pv deletion
do not enable rook module
reduce activeCount to 1 to save resources
run cephnfs ci before cephfs ci since it cephfs
ci is more resource intensive.

Signed-off-by: Rakshith R rar@redhat.com

Resolves #

Checklist:

Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
Reviewed the developer guide on Submitting a Pull Request
Pending release notes updated with breaking and/or notable changes for the next minor release.
Documentation has been updated, if necessary.
Unit tests have been added, if necessary.
Integration tests have been added, if necessary.

mergify · 2022-07-05T17:27:45Z

This pull request has merge conflicts that must be resolved before it can be merged. @Rakshith-R please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

tests/framework/installer/ceph_installer.go

tests/integration/ceph_base_nfs_test.go

mergify · 2022-07-25T15:56:14Z

This pull request has merge conflicts that must be resolved before it can be merged. @Rakshith-R please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

mergify · 2022-08-11T19:28:42Z

This pull request has merge conflicts that must be resolved before it can be merged. @Rakshith-R please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

mergify · 2022-09-13T13:56:44Z

This pull request has merge conflicts that must be resolved before it can be merged. @Rakshith-R please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

Rakshith-R · 2022-09-26T10:41:36Z

tests/framework/installer/ceph_manifests.go

@@ -153,8 +153,6 @@ spec:
    modules:
    - name: pg_autoscaler
      enabled: true
-    - name: rook


This was the reason why nfs pvc creation was failing.

travisn

LGTM, before I approve if @BlaineEXE could take a look.

BlaineEXE · 2022-09-27T15:51:29Z

tests/framework/utils/k8s_helper.go

@@ -272,7 +272,7 @@ func (k8sh *K8sHelper) WaitForCustomResourceDeletion(namespace, name string, che
 		return err
 	}
 	logger.Errorf("gave up deleting custom resource %q ", name)
-	return nil
+	return fmt.Errorf("Timedout waiting for deletion of customer resource %q", name)


Suggested change

return fmt.Errorf("Timedout waiting for deletion of customer resource %q", name)

return fmt.Errorf("Timed out waiting for deletion of custom resource %q", name)

BlaineEXE · 2022-09-27T15:52:10Z

tests/framework/utils/k8s_helper.go

-		if err != nil && kerrors.IsNotFound(err) {
+		if kerrors.IsNotFound(err) {


I think the err != nil part is important to make sure this doesn't segfault. Why was this change made?

done reverted it back.
I don't remember why this was changed.

Rakshith-R · 2022-10-06T11:53:10Z

@Mergifyio rebase

This commit anabled nfs csi ci and add fixes/improvements to it like the following: - verify deletion of cephnfs and .nfs pool before proceeding - verify pv deletion - do not enable rook module - reduce activeCount to 1 to save resources - run cephnfs ci before cephfs ci since it cephfs ci is more resource intensive. Signed-off-by: Rakshith R <rar@redhat.com>

mergify · 2022-10-06T11:53:48Z

rebase

✅ Branch has been successfully rebased

ci: enable and fixes for nfs ci (backport #10510)

Rakshith-R force-pushed the fix-nfs-ci branch 10 times, most recently from d25d022 to 591e3f3 Compare July 4, 2022 07:49

Rakshith-R force-pushed the fix-nfs-ci branch 9 times, most recently from 8734cc4 to 01bb73e Compare July 5, 2022 13:54

Rakshith-R force-pushed the fix-nfs-ci branch 4 times, most recently from 3ca2ebc to c0df9f3 Compare July 6, 2022 10:12

BlaineEXE reviewed Jul 6, 2022

View reviewed changes

tests/framework/installer/ceph_installer.go Outdated Show resolved Hide resolved

BlaineEXE reviewed Jul 6, 2022

View reviewed changes

tests/integration/ceph_base_nfs_test.go Outdated Show resolved Hide resolved

Rakshith-R force-pushed the fix-nfs-ci branch 2 times, most recently from 4484071 to d7fe636 Compare August 25, 2022 10:34

Rakshith-R force-pushed the fix-nfs-ci branch 8 times, most recently from 582d43c to 3d2f189 Compare September 3, 2022 11:30

Rakshith-R force-pushed the fix-nfs-ci branch 2 times, most recently from 9771c4c to dfee738 Compare September 26, 2022 06:05

Rakshith-R changed the title ~~ci: verify deletion of cephnfs and .nfs pool before proceeding~~ ci: enable and fixes for nfs ci Sep 26, 2022

Rakshith-R linked an issue Sep 26, 2022 that may be closed by this pull request

NFS CI test is disabled #10518

Closed

Rakshith-R marked this pull request as ready for review September 26, 2022 10:40

Rakshith-R requested review from travisn and BlaineEXE September 26, 2022 10:40

Rakshith-R commented Sep 26, 2022

View reviewed changes

travisn reviewed Sep 26, 2022

View reviewed changes

BlaineEXE requested changes Sep 27, 2022

View reviewed changes

Rakshith-R force-pushed the fix-nfs-ci branch from dfee738 to 623e13b Compare September 28, 2022 16:00

Rakshith-R requested a review from BlaineEXE September 28, 2022 16:01

travisn force-pushed the fix-nfs-ci branch from 623e13b to be10dac Compare October 6, 2022 11:53

BlaineEXE approved these changes Oct 6, 2022

View reviewed changes

BlaineEXE merged commit a809de2 into rook:master Oct 6, 2022

BlaineEXE added the backport-release-1.10 label Oct 6, 2022

mergify bot mentioned this pull request Oct 6, 2022

ci: enable and fixes for nfs ci (backport #10510) #11117

Merged

mergify bot added a commit that referenced this pull request Oct 20, 2022

Merge pull request #11117 from rook/mergify/bp/release-1.10/pr-10510

4e1c154

ci: enable and fixes for nfs ci (backport #10510)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: enable and fixes for nfs ci #10510

ci: enable and fixes for nfs ci #10510

Rakshith-R commented Jun 27, 2022 •

edited

mergify bot commented Jul 5, 2022

mergify bot commented Jul 25, 2022

mergify bot commented Aug 11, 2022

mergify bot commented Sep 13, 2022

Rakshith-R Sep 26, 2022

travisn left a comment

BlaineEXE Sep 27, 2022

BlaineEXE Sep 27, 2022

Rakshith-R Sep 28, 2022

Rakshith-R commented Oct 6, 2022

mergify bot commented Oct 6, 2022

	return fmt.Errorf("Timedout waiting for deletion of customer resource %q", name)
	return fmt.Errorf("Timed out waiting for deletion of custom resource %q", name)

		if err != nil && kerrors.IsNotFound(err) {
		if kerrors.IsNotFound(err) {

ci: enable and fixes for nfs ci #10510

ci: enable and fixes for nfs ci #10510

Conversation

Rakshith-R commented Jun 27, 2022 • edited

mergify bot commented Jul 5, 2022

mergify bot commented Jul 25, 2022

mergify bot commented Aug 11, 2022

mergify bot commented Sep 13, 2022

Rakshith-R Sep 26, 2022

Choose a reason for hiding this comment

travisn left a comment

Choose a reason for hiding this comment

BlaineEXE Sep 27, 2022

Choose a reason for hiding this comment

BlaineEXE Sep 27, 2022

Choose a reason for hiding this comment

Rakshith-R Sep 28, 2022

Choose a reason for hiding this comment

Rakshith-R commented Oct 6, 2022

mergify bot commented Oct 6, 2022

✅ Branch has been successfully rebased

Rakshith-R commented Jun 27, 2022 •

edited