rgw: handle insecure flag skip for obc in the tls config #11018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OBC provisioner ignores insecure skip flag even if it is declared for TLS auth, hence bucket creation was failing Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
subhamkrai
reviewed
Sep 20, 2022
| s3svc, err := object.NewS3Agent(objectUser.Keys[0].AccessKey, objectUser.Keys[0].SecretKey, p.getObjectStoreEndpoint(), logger.LevelAt(capnslog.DEBUG), p.tlsCert) | ||
| var s3svc *object.S3Agent | ||
| if p.insecureTLS { | ||
| s3svc, err = object.NewInsecureS3Agent(objectUser.Keys[0].AccessKey, objectUser.Keys[0].SecretKey, p.getObjectStoreEndpoint(), logger.LevelAt(capnslog.DEBUG)) |
There was a problem hiding this comment.
maybe add a debug mode log for both insecure and secure tls config?
There was a problem hiding this comment.
maybe no need to log this, since it's common behavior to use the different s3 agent.
travisn
reviewed
Sep 26, 2022
| s3svc, err := object.NewS3Agent(objectUser.Keys[0].AccessKey, objectUser.Keys[0].SecretKey, p.getObjectStoreEndpoint(), logger.LevelAt(capnslog.DEBUG), p.tlsCert) | ||
| var s3svc *object.S3Agent | ||
| if p.insecureTLS { | ||
| s3svc, err = object.NewInsecureS3Agent(objectUser.Keys[0].AccessKey, objectUser.Keys[0].SecretKey, p.getObjectStoreEndpoint(), logger.LevelAt(capnslog.DEBUG)) |
There was a problem hiding this comment.
maybe no need to log this, since it's common behavior to use the different s3 agent.
BlaineEXE
approved these changes
Sep 30, 2022
mergify bot
added a commit
that referenced
this pull request
Sep 30, 2022
rgw: handle insecure flag skip for obc in the tls config (backport #11018)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
OBC provisioner ignores insecure skip flag even if it is declared for TLS auth, hence bucket creation was failing
Signed-off-by: Jiffin Tony Thottan thottanjiffin@gmail.com
Which issue is resolved by this Pull Request:
Resolves #10910
Checklist:
skip-cion the PR.