osd: clarify lv is not picked by filters #11069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that must be resolved before it can be merged. @satoru-takeuchi please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork |
LVM logical volumes are not picked by `deviceFilter`, `devicePathFilter`, and `useAllDevices`. It's to prevent old version's users from creating lv-backed osd during upgrading rook by accident. It's better to clarify lvs are not picked by filters" in docs and suggest users to use exact device name instead. Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
satoru-takeuchi
force-pushed
the
osd-clarify-lv-is-not-picked-by-filters
branch
from
da1e524
to
b6a6f66
Compare
travisn
approved these changes
Sep 28, 2022
mergify bot
added a commit
that referenced
this pull request
Sep 28, 2022
osd: clarify lv is not picked by filters (backport #11069)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
LVM logical volumes are not picked by
deviceFilter,devicePathFilter, anduseAllDevices. It's to prevent old version's users from creating lv-backed osd during upgrading rook by accident.It's better to clarify lvs are not picked by filters" in docs and suggest users to use exact device name instead.
Which issue is resolved by this Pull Request:
Resolves #11032
Checklist:
skip-cion the PR.