osd: Recommend removing memory limits from osd prepare job #11109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The osd prepare job is not recommended to have memory limits since it's a one-time operation depending on the size of the disk that must be allowed to complete successfully. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
satoru-takeuchi
approved these changes
Oct 5, 2022
This was referenced Oct 5, 2022
mergify bot
added a commit
that referenced
this pull request
Oct 5, 2022
osd: Recommend removing memory limits from osd prepare job (backport #11109)
mergify bot
added a commit
that referenced
this pull request
Oct 5, 2022
osd: Recommend removing memory limits from osd prepare job (backport #11109)
HoKim98
added a commit
to SmartX-Team/OpenARK
that referenced
this pull request
Oct 8, 2022
* See note: rook/rook#11103 * See note: rook/rook#11109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The osd prepare job is not recommended to have memory limits since it's a one-time operation depending on the size of the disk that must be allowed to complete successfully.
This is a follow-up from #11103 where more data showed we really should not recommend limits on the osd prepare.
Which issue is resolved by this Pull Request:
Resolves #10219
Checklist:
skip-cion the PR.