csi: add a parameter to modify the maxUnavailable value of rbd daemonset. #11334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peng225
force-pushed
the
addUpgradeStrategyParameters
branch
2 times, most recently
from
c38351c
to
3acb145
Compare
The default value of maxUnavailable of daemonset is 1. Sometimes the upgrade can be slow due to this setting. So I add a parameter to change the value for rbd daemonset. Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp> Co-authored-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp> Co-authored-by: Yuji Ito <llamerada.jp@gmail.com>
peng225
force-pushed
the
addUpgradeStrategyParameters
branch
from
3acb145
to
ac4b47d
Compare
satoru-takeuchi
approved these changes
Nov 24, 2022
mergify bot
added a commit
that referenced
this pull request
Nov 24, 2022
csi: add a parameter to modify the maxUnavailable value of rbd daemonset. (backport #11334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The default value of maxUnavailable of daemonset is 1.
Sometimes the upgrade can be slow due to this setting.
So I add a parameter to change the value for rbd daemonset.
Which issue is resolved by this Pull Request:
Resolves no issue.
Checklist:
skip-cion the PR.