osd: improve log on specifying lv and loop device as osd #11361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use LVM logical volumes and loop devices as OSD iff we specify them in the `devices` field. If we use filters like `deviceFilter`, these devices are not picked with a log message which let users to specify the exact device name. It's better to mention which field users should use in this case. Closes: rook#11353 Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
travisn
approved these changes
Nov 29, 2022
mergify bot
added a commit
that referenced
this pull request
Nov 29, 2022
osd: improve log on specifying lv and loop device as osd (backport #11361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
We can use LVM logical volumes and loop devices as OSD iff we specify them in the
devicesfield. If we use filters likedeviceFilter, these devices are not picked with a log message which let users specify the exact device name. It's better to mention which field users should use in this case.Which issue is resolved by this Pull Request:
Resolves #11353
Checklist:
skip-cion the PR.