core: Allow ceph.conf to be updated if already exists #11399
Conversation
The ceph.conf was being written with 0x444 permissions, which means the file could not be updated if it already exists. Specifically, when an osd is purged, if the operation is retried multiple times, only the first operation was succeeding. The subsequent requests to purge an osd were failing due to the config already existing. If we make the config writeable with 0x644 then the operator can always write the file. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The OSD purge was printing an incorrect sentence, so this now fixes the grammar. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
osd-purge-config
branch
from
81bc6e7
to
2a16cd8
Compare
| @@ -293,7 +293,7 @@ func WriteCephConfig(context *clusterd.Context, clusterInfo *ClusterInfo) error | |||
| if err != nil { | |||
| return errors.Wrap(err, "failed to copy connection config to /etc/ceph. failed to read the connection config") | |||
| } | |||
| err = ioutil.WriteFile(DefaultConfigFilePath(), src, 0444) | |||
| err = ioutil.WriteFile(DefaultConfigFilePath(), src, 0600) | |||
There was a problem hiding this comment.
Just to check to give this update permission to ceph.conf doesn't harm or create any secruity problem
There was a problem hiding this comment.
Only the operator has access to this inside the pod, so it will be fine. It's really just giving write access to itself. Notice in other places in the operator code we also use 0600 for some other config files.
The command is generating the ceph.conf needed to run the ceph commands during the purge, whether the command is run in its own pod or as part of the operator pod. It's just a different path than the path where the operator usually generates the ceph.conf. |
core: Allow ceph.conf to be updated if already exists (backport #11399)
Description of your changes:
The ceph.conf was being written with 0x444 permissions, which means the file could not be updated if it already exists. Specifically, when an osd is purged, if the operation is retried multiple times, only the first operation was succeeding. The subsequent requests to purge an osd were failing due to the config already existing. If we make the config writeable with 0x644 then the operator can always write the file.
A small typo is also fixed in the osd purge message.
Checklist:
skip-cion the PR.