Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move to Go 1.19 as default version for building services #11427

Merged
merged 1 commit into from
Dec 19, 2022
Merged

build: move to Go 1.19 as default version for building services #11427

merged 1 commit into from
Dec 19, 2022

Conversation

Rajpratik71
Copy link
Contributor

Description of your changes:

Go 1.18.5 and other Go 1.18 version patches provided many vulnerability fixes
but as go.mod doesn't support minor version i.e why moving to next go release

Signed-off-by: Pratik Raj rajpratik71@gmail.com

Which issue is resolved by this Pull Request:
Resolves #11176

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The golang linter is failing with this error:

  Running [/home/runner/golangci-lint-1.45.2-linux-amd64/golangci-lint run --out-format=github-actions -E gosec --timeout=6m] in [] ...
  panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
  
  goroutine 1 [running]:
  github.com/go-critic/go-critic/checkers.init.22()
  	github.com/go-critic/go-critic@v0.6.2/checkers/embedded_rules.go:46 +0x4b4
  
  Error: golangci-lint exit with code 2
  Ran golangci-lint in 9819ms

go.mod Outdated Show resolved Hide resolved
Go 1.18.5 and other Go 1.18 version patches provided many vulnerability fixes
but as go.mod doesn't support minor version i.e why moving to next go release

Signed-off-by: Pratik Raj <rajpratik71@gmail.com>
@travisn travisn merged commit 5f059ad into rook:master Dec 19, 2022
mergify bot added a commit that referenced this pull request Dec 19, 2022
build: move to Go 1.19 as default version for building services (backport #11427)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build services with updated go version to reduce vulnerability
2 participants