Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: adding logs for debugging admission controller deletion #11448

Merged
merged 1 commit into from
Dec 16, 2022
Merged

operator: adding logs for debugging admission controller deletion #11448

merged 1 commit into from
Dec 16, 2022

Conversation

subhamkrai
Copy link
Contributor

Signed-off-by: subhamkrai srai@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@subhamkrai
operator: adding logs for debugging
de604d3 
Signed-off-by: subhamkrai <srai@redhat.com>
@subhamkrai subhamkrai mentioned this pull request Dec 16, 2022
Merged
7 tasks
@satoru-takeuchi satoru-takeuchi merged commit 3a525f7 into rook:master Dec 16, 2022
@mergify mergify bot mentioned this pull request Dec 16, 2022
Merged
@satoru-takeuchi
Copy link
Member

multi-cluster-mirroring fails but I decided to merge this PR. It's because apparently this canary-test problem doesn't correspond to this PR and is now under investigation.

@subhamkrai
Copy link
Contributor Author

multi-cluster-mirroring fails but I decided to merge this PR. It's because apparently this canary-test problem doesn't correspond to this PR and is now under investigation.

Thanks

mergify bot added a commit that referenced this pull request Dec 16, 2022
@mergify
Merge pull request #11449 from rook/mergify/bp/release-1.10/pr-11448
9d56ff2 
operator: adding logs for debugging (backport #11448)
@subhamkrai subhamkrai deleted the fix-log branch December 16, 2022 06:16
@travisn travisn changed the title operator: adding logs for debugging operator: adding logs for debugging admission controller deletion Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoru-takeuchi satoru-takeuchi satoru-takeuchi approved these changes

@travisn travisn Awaiting requested review from travisn

Assignees
No one assigned
Labels
backport-release-1.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@subhamkrai @satoru-takeuchi