csi: add default version to images if it is missing #11577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
reviewed
Jan 23, 2023
pkg/operator/ceph/csi/util.go
Outdated
Comment on lines
259
to
262
| func getImage( | ||
| data map[string]string, | ||
| settingName string, | ||
| defaultImage string) string { |
There was a problem hiding this comment.
Suggested change
| func getImage( | |
| data map[string]string, | |
| settingName string, | |
| defaultImage string) string { | |
| func getImage(data map[string]string,configKey,defaultImage string) string { |
Rakshith-R
force-pushed
the
default-img-version
branch
from
8f101f4
to
9d21a00
Compare
travisn
requested changes
Jan 23, 2023
| @@ -27,6 +27,12 @@ ROOK_CSI_SNAPSHOTTER_IMAGE: "registry.k8s.io/sig-storage/csi-snapshotter:v6.2.1" | |||
| ROOK_CSIADDONS_IMAGE: "quay.io/csiaddons/k8s-sidecar:v0.5.0" | |||
| ``` | |||
|
|
|||
| !!! note | |||
There was a problem hiding this comment.
Instead of a note how about a header so it's obvious this feature is for using a private repo?
Suggested change
| !!! note | |
| ### **Use private repo** |
Rook will now append internal default versions to custom csi image variables passed down if version is missing in them. This will enable users using their private registries to just pass different image names while rook takes care of adding default versions to them. Resolves: rook#10529 Signed-off-by: Rakshith R <rar@redhat.com>
Rakshith-R
force-pushed
the
default-img-version
branch
from
9d21a00
to
12fd87f
Compare
travisn
approved these changes
Jan 24, 2023
mergify bot
added a commit
that referenced
this pull request
Jan 24, 2023
csi: add default version to images if it is missing (backport #11577)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rook will now append internal default versions to custom csi image variables passed down if version is missing in them.
This will enable users using their private registries to just pass different image names while rook takes care of adding default versions to them.
Resolves: #10529
Signed-off-by: Rakshith R rar@redhat.com
Checklist:
skip-cion the PR.