Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file: Disable active standby when set to false #12981

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

travisn
Copy link
Member

@travisn travisn commented Oct 2, 2023

Description of your changes:
The activeStandby property of the filesystem CR was not taking effect when changed from true to false. The active standby was only being enabled when true, but never applied when changed to false.

Which issue is resolved by this Pull Request:
Resolves #12576

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

The activeStandby property of the filesystem CR was not
taking effect when changed from true to false. The standby
was only being enabled when true, but never applied when
changed to false.

Signed-off-by: travisn <tnielsen@redhat.com>
@BlaineEXE
Copy link
Member

Upgrade test flaked on RGW, which is after CephFS tests, so I think this looks good to merge

@travisn travisn merged commit 0e2359d into rook:master Oct 2, 2023
48 of 50 checks passed
@travisn travisn deleted the filesystem-standby branch October 2, 2023 16:10
mergify bot added a commit that referenced this pull request Oct 2, 2023
file: Disable active standby when set to false (backport #12981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setting activeStandby: false on existing CephFilesystem has no effect
2 participants