core: Fix golang linter issues with variables in loops and update linter version #13324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhamkrai
previously requested changes
Dec 5, 2023
travisn
force-pushed
the
golangci-lint-update
branch
2 times, most recently
from
b1982d6
to
eb28d6c
Compare
Loop variables cannot be reliably uses since they will change with each iteration. Update these loop variable uses to be safe by indexing the slice rather than using the loop variable directly. Also suppress the linter issues for passwords used in tests. Signed-off-by: travisn <tnielsen@redhat.com>
travisn
force-pushed
the
golangci-lint-update
branch
from
eb28d6c
to
6f8e424
Compare
BlaineEXE
approved these changes
Dec 5, 2023
travisn
added a commit
that referenced
this pull request
Dec 5, 2023
core: Fix golang linter issues with variables in loops and update linter version (backport #13324)
mergify bot
added a commit
that referenced
this pull request
Jan 5, 2024
core: Fix golang linter issues with variables in loops and update linter version (backport #13324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop variables cannot be reliably uses since they will change with each iteration. Update these loop variable uses to be safe by indexing the slice rather than using the loop variable directly.
Also suppress the linter issues for passwords used in tests.
Updates the golangci-linter version to v1.55
Checklist: