manifest: Remove pg_autoscaler from mgr modules examples #13588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlaineEXE
approved these changes
Jan 19, 2024
BlaineEXE
reviewed
Jan 19, 2024
deploy/examples/cluster.yaml
Outdated
Comment on lines
62
to
63
| #- name: rook | ||
| # enabled: true |
There was a problem hiding this comment.
Nit: I usually see a space after comments in yaml when doing this with vscode.
Suggested change
| #- name: rook | |
| # enabled: true | |
| # - name: rook | |
| # enabled: true |
The pg_autoscaler mgr module is no longer possible to disable. Ceph requires the module to always be enabled. Now the autoscaling configuration is done with a per-pool setting. Now the rook module is shown as an example to enable. Signed-off-by: travisn <tnielsen@redhat.com>
travisn
force-pushed
the
autoscale-module
branch
from
747b648
to
f0c30e2
Compare
travisn
added a commit
that referenced
this pull request
Jan 19, 2024
manifest: Remove pg_autoscaler from mgr modules examples (backport #13588)
travisn
added a commit
to travisn/rook
that referenced
this pull request
Feb 13, 2024
The pg_autoscaler is always enabled by ceph and cannot be disabled. In rook#13588 the pg_autoscaler config was removed from the main example. Now the remaining config for the pg_autoscaler is removed as well. Signed-off-by: travisn <tnielsen@redhat.com>
6 tasks
travisn
added a commit
to travisn/rook
that referenced
this pull request
Feb 14, 2024
The pg_autoscaler is always enabled by ceph and cannot be disabled. In rook#13588 the pg_autoscaler config was removed from the main example. Now the remaining config for the pg_autoscaler is removed as well. Signed-off-by: travisn <tnielsen@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pg_autoscaler mgr module is no longer possible to disable. Ceph requires the module to always be enabled. Now the autoscaling configuration is done with a per-pool setting.
Now the rook module is shown as an example to enable.
@rkachach As a separate topic, let's discuss when we should enable the
rookmodule by default.Checklist: