Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: Remove remaining pg_autoscaler examples #13766

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

travisn
Copy link
Member

@travisn travisn commented Feb 13, 2024

The pg_autoscaler is always enabled by ceph and cannot be disabled. In #13588 the pg_autoscaler config was removed from the main example. Now the remaining config for the pg_autoscaler is removed as well since being missed in the previous PR.

Issue resolved by this Pull Request:
Resolves #13346

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link
Contributor

@sp98 sp98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

pgAutoScalerModuleName reference can be removed from this method

The pg_autoscaler is always enabled by ceph and cannot be disabled.
In a previous PR the pg_autoscaler config was removed from the main example.
Now the remaining config for the pg_autoscaler is removed as well.

Signed-off-by: travisn <tnielsen@redhat.com>
@travisn travisn merged commit 73f22c3 into rook:master Feb 15, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to disable pg_autoscaler and manually set PGs on already created CephCluster
2 participants