Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter: Skip reconcile on exporter deletion #13597

Merged
merged 1 commit into from Jan 22, 2024

Conversation

travisn
Copy link
Member

@travisn travisn commented Jan 19, 2024

The exporter pod is ephemeral and frequently being deleted and re-created when ceph daemons are created. Therefore, we need to skip reconciling based on the deletion of the exporter deployment.

Issue resolved by this Pull Request:
Resolves #12944

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

The exporter pod is ephemeral and frequently being deleted
and re-created when ceph daemons are created. Therefore,
we need to skip reconciling based on the deletion
of the exporter deployment.

Signed-off-by: travisn <tnielsen@redhat.com>
Copy link
Member

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@travisn travisn merged commit 76b97dc into rook:master Jan 22, 2024
49 of 50 checks passed
mergify bot added a commit that referenced this pull request Jan 22, 2024
exporter: Skip reconcile on exporter deletion (backport #13597)
travisn added a commit that referenced this pull request Jan 22, 2024
exporter: Skip reconcile on exporter deletion (backport #13597)
@travisn travisn deleted the no-exporter-reconcile branch January 25, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous reconcile loop on upgrade to 18.2.0
4 participants