New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Increase resource limits to 1.5 CPU #13619
Conversation
8701674
to
4b3f709
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we update examples here
rook/deploy/examples/operator.yaml
Lines 671 to 678 in e8002a6
# Recommended resource requests and limits, if desired | |
#resources: | |
# limits: | |
# cpu: 500m | |
# memory: 512Mi | |
# requests: | |
# cpu: 100m | |
# memory: 128Mi |
@subhamkrai wrote:
sounds like a good idea to me! |
and also operator .yaml |
Good catch, thanks |
The operator needs to burst significantly when reconciling, then will quiet down and nearly not consume any cpu. Therefore, we allow the operator to burst to more than a full cpu instead of limiting it to a half cpu. Signed-off-by: travisn <tnielsen@redhat.com>
4b3f709
to
ca28887
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. I feel like it could be worth doing some golang profiling on the operator when it's running to see if there are any places in the code that are particular resource hogs. But also, 1.5 CPUs isn't a ridiculous amount IMO.
operator: Increase resource limits to 1.5 CPU (backport #13619)
The operator needs to burst significantly when reconciling, then will quiet down and nearly not consume any cpu. Therefore, we allow the operator to burst to 1.5 cpu instead of limiting it to a 0.5 cpu.
Related discussion here.
Checklist: