Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Increase resource limits to 1.5 CPU #13619

Merged
merged 1 commit into from Jan 25, 2024

Conversation

travisn
Copy link
Member

@travisn travisn commented Jan 24, 2024

The operator needs to burst significantly when reconciling, then will quiet down and nearly not consume any cpu. Therefore, we allow the operator to burst to 1.5 cpu instead of limiting it to a 0.5 cpu.

Related discussion here.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we update examples here

# Recommended resource requests and limits, if desired
#resources:
# limits:
# cpu: 500m
# memory: 512Mi
# requests:
# cpu: 100m
# memory: 128Mi
and similar in operator-openshift.yaml files?

@obnoxxx
Copy link
Contributor

obnoxxx commented Jan 25, 2024

@subhamkrai wrote:

should we update examples here
and similar in operator-openshift.yaml files?

sounds like a good idea to me!

@parth-gr
Copy link
Member

should we update examples here

# Recommended resource requests and limits, if desired
#resources:
# limits:
# cpu: 500m
# memory: 512Mi
# requests:
# cpu: 100m
# memory: 128Mi

and similar in operator-openshift.yaml files?

and also operator .yaml

@travisn
Copy link
Member Author

travisn commented Jan 25, 2024

should we update examples here

# Recommended resource requests and limits, if desired
#resources:
# limits:
# cpu: 500m
# memory: 512Mi
# requests:
# cpu: 100m
# memory: 128Mi

and similar in operator-openshift.yaml files?

Good catch, thanks

The operator needs to burst significantly when reconciling,
then will quiet down and nearly not consume any cpu.
Therefore, we allow the operator to burst to more than
a full cpu instead of limiting it to a half cpu.

Signed-off-by: travisn <tnielsen@redhat.com>
@travisn travisn changed the title operator: Increase limits to a full CPU operator: Increase resource limits to 1.5 CPU Jan 25, 2024
Copy link
Member

@BlaineEXE BlaineEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I feel like it could be worth doing some golang profiling on the operator when it's running to see if there are any places in the code that are particular resource hogs. But also, 1.5 CPUs isn't a ridiculous amount IMO.

@travisn travisn merged commit 3512e14 into rook:master Jan 25, 2024
48 of 50 checks passed
@travisn travisn deleted the operator-limits branch January 25, 2024 18:14
mergify bot added a commit that referenced this pull request Jan 25, 2024
operator: Increase resource limits to 1.5 CPU (backport #13619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants