osd: correct counting the devices when metadataDevice is set #13673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoru-takeuchi
force-pushed
the
correct-counting-the-devices-when-metadatadevice-is-set
branch
from
5e53d5b
to
70d258f
Compare
sp98
approved these changes
Feb 6, 2024
satoru-takeuchi
force-pushed
the
correct-counting-the-devices-when-metadatadevice-is-set
branch
from
70d258f
to
6073762
Compare
|
@satoru-takeuchi please just rebase one more time to pick up all the CI fixes |
The validation logic of checking the number of devices is wrong when `metadataDevice` is set and `osdsPerDevice` > 1. `len(cvReports)` is the expected number of OSDs and is the number of specified data devices multiplied by `osdsPerDevice`. Closes: rook#13637 Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
satoru-takeuchi
force-pushed
the
correct-counting-the-devices-when-metadatadevice-is-set
branch
from
6073762
to
753bbfe
Compare
mergify bot
added a commit
that referenced
this pull request
Feb 8, 2024
osd: correct counting the devices when metadataDevice is set (backport #13673)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation logic of checking the number of devices is wrong when
metadataDeviceis set andosdsPerDevice> 1.len(cvReports)is the expected number of OSDs and is the number of specified data devices multiplied byosdsPerDevice.Issue resolved by this Pull Request:
Resolves #13637
Checklist: