Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External: fix syntax error import-external-cluster.sh #13780

Merged
merged 1 commit into from Feb 16, 2024

Conversation

timolow
Copy link
Contributor

@timolow timolow commented Feb 15, 2024

When invoking the import-external-cluster.sh script a syntax issue is preventing the script from completing.

The StorageClass "cephfs" is invalid: provisioner: Invalid value: "rook-ceph=.cephfs.csi.ceph.com": name part must consist of alphanumeric characters, '-', '_' or '.', and must st
art and end with an alphanumeric character (e.g. 'MyName',  or 'my.name',  or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]')

Issue resolved by this Pull Request:
Resolves 13679

Signed-off-by: Tim Olow tim@eth0.com

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, please just see the developer guide for the needed commit prefix and description, thanks

@timolow timolow changed the title Remove '= ' in import-external-cluster.sh preventing script from importing external cephfs cluster correctly External: fix syntax error import-external-cluster.sh Feb 15, 2024
@timolow timolow requested a review from travisn February 15, 2024 19:40
@travisn
Copy link
Member

travisn commented Feb 15, 2024

@timolow It's not the PR title, it's the commit title and description that is needed. Please see the developer guide previously linked.

Copy link
Member

@parth-gr parth-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Removed = that was preventing the import-external-cluster.sh script from
importing external ceph cluster into k8s.

Fixes rook#13679

Signed-off-by: Tim Olow <tim@eth0.com>
@timolow
Copy link
Contributor Author

timolow commented Feb 16, 2024

@timolow It's not the PR title, it's the commit title and description that is needed. Please see the developer guide previously linked.

Fixed up the commit issue.

Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@travisn travisn merged commit da08206 into rook:master Feb 16, 2024
50 of 51 checks passed
travisn added a commit that referenced this pull request Feb 16, 2024
External: fix syntax error import-external-cluster.sh (backport #13780)
@timolow timolow deleted the patch-1 branch February 16, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The StorageClass "cephfs" is invalid: provisioner: Invalid value: "rook-ceph=.cephfs.csi.ceph.com":
3 participants