New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External: fix syntax error import-external-cluster.sh #13780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, please just see the developer guide for the needed commit prefix and description, thanks
@timolow It's not the PR title, it's the commit title and description that is needed. Please see the developer guide previously linked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Removed = that was preventing the import-external-cluster.sh script from importing external ceph cluster into k8s. Fixes rook#13679 Signed-off-by: Tim Olow <tim@eth0.com>
Fixed up the commit issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
External: fix syntax error import-external-cluster.sh (backport #13780)
When invoking the import-external-cluster.sh script a syntax issue is preventing the script from completing.
Issue resolved by this Pull Request:
Resolves 13679
Signed-off-by: Tim Olow tim@eth0.com
Checklist: