Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The StorageClass "cephfs" is invalid: provisioner: Invalid value: "rook-ceph=.cephfs.csi.ceph.com": #13679

Closed
achernya opened this issue Feb 3, 2024 · 3 comments · Fixed by #13780
Labels

Comments

@achernya
Copy link

achernya commented Feb 3, 2024

Is this a bug report or feature request?
Bug report

Deviation from expected behavior:
I believe there's a typo on https://github.com/rook/rook/blob/master/deploy/examples/import-external-cluster.sh#L27

When I attempt to use the import-external-cluster.sh script, I get the following output:

The StorageClass "cephfs" is invalid: provisioner: Invalid value: "rook-ceph=.cephfs.csi.ceph.com": name part must consist of alphanumeric characters, '-', '_' or '.', and must st
art and end with an alphanumeric character (e.g. 'MyName',  or 'my.name',  or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]')

Expected behavior:

[snip]
storageclass.storage.k8s.io/cephfs created                                               

How to reproduce it (minimal and precise):
Follow the instructions at https://rook.io/docs/rook/latest-release/CRDs/Cluster/external-cluster/?h=external#import-the-source-data

I removed the stray =, and the script passes successfully. I'm happy to submit a PR --- I just want confirmation that the fix makes sense :)

File(s) to submit:
N/A

  • Cluster CR (custom resource), typically called cluster.yaml, if necessary
    N/A

Logs to submit:
N/A

  • Operator's logs, if necessary

  • Crashing pod(s) logs, if necessary

    To get logs, use kubectl -n <namespace> logs <pod name>
    When pasting logs, always surround them with backticks or use the insert code button from the Github UI.
    Read GitHub documentation if you need help.

Cluster Status to submit:

  • Output of kubectl commands, if necessary

    To get the health of the cluster, use kubectl rook-ceph health
    To get the status of the cluster, use kubectl rook-ceph ceph status
    For more details, see the Rook kubectl Plugin

Environment:

  • OS (e.g. from /etc/os-release):Debian GNU/Linux 12 (bookworm)
  • Kernel (e.g. uname -a): 6.1.0-17-cloud-amd64
  • Cloud provider or hardware configuration: v1.13.3
  • Rook version (use rook version inside of a Rook Pod):
  • Storage backend version (e.g. for ceph do ceph -v):
  • Kubernetes version (use kubectl version): v1.29.1
  • Kubernetes cluster type (e.g. Tectonic, GKE, OpenShift):
  • Storage backend status (e.g. for Ceph use ceph health in the Rook Ceph toolbox):
@achernya achernya added the bug label Feb 3, 2024
@achernya
Copy link
Author

achernya commented Feb 3, 2024

Looks like this was introduced in c35a853, previously there was no =. @Madhu-1

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 5, 2024

@achernya Yes if you remove = that is enough, please feel free to fix it :)

timolow added a commit to timolow/rook that referenced this issue Feb 15, 2024
timolow added a commit to timolow/rook that referenced this issue Feb 16, 2024
Removed = that was preventing the import-external-cluster.sh script from
importing external ceph cluster into k8s.

Fixes rook#13679

Signed-off-by: Tim Olow <tim@eth0.com>
mergify bot pushed a commit that referenced this issue Feb 16, 2024
Removed = that was preventing the import-external-cluster.sh script from
importing external ceph cluster into k8s.

Fixes #13679

Signed-off-by: Tim Olow <tim@eth0.com>
(cherry picked from commit 7dcffae)
@achernya
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants